fix: Hosts not able to cancel/reschedule the event when Disable Rescheduling/Cancelling is enabled by asadath1395 · Pull Request #22281 · calcom/cal.com

asadath1395 · 2025-07-07T06:03:50Z

What does this PR do?

Hosts not able to cancel/reschedule the event when Disable Rescheduling/Cancelling is enabled

Fixes Disable cancellation feature disables the option for the host as well #22271 (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

Before

https://www.loom.com/share/bf768bc270e04c48b37ec8d9379a8a0a?sid=c4fa7153-8794-47ef-8320-f42252c880b3

After

https://www.loom.com/share/5b130406f3364ec591764672e8a9660a?sid=6c02726f-84c4-4862-b08b-aed83d956c4f

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Check the videos above

…eduling/Cancelling is enabled

vercel · 2025-07-07T06:03:57Z

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

graphite-app · 2025-07-07T06:05:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/07/25)

1 label was added to this PR based on Keith Williams's automation.

cubic-dev-ai

cubic found 2 issues across 6 files. Review them in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

apps/web/lib/reschedule/[uid]/getServerSideProps.ts

cubic-dev-ai · 2025-07-07T06:08:23Z

apps/web/playwright/booking-pages.e2e.ts

+    const [user] = users.get();
+    await user.apiLogin();
+
+    await page.goto(`/booking/${bookingId}`);


Rule violated: E2E Tests Best Practices

Missing expect(page).toHaveURL() after navigation. According to the E2E Best Practices guideline, tests must assert the final URL immediately after page.goto to fail fast on unexpected redirects.

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

kart1ka

Along with the host, Team/Org Admin and Owner should also be able to reschedule or cancel the booking.

kart1ka · 2025-07-07T17:38:45Z

Hi @asadath1395, Left a comment. There is a type check failing, pls address that as well.

…able-rescheduling-cancelling

…e disabled in event type

…com/asadath1395/cal.com into fix/disable-rescheduling-cancelling

…able-rescheduling-cancelling

cubic-dev-ai

cubic found 2 issues across 9 files. Review them in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

cubic-dev-ai · 2025-07-09T02:55:07Z

apps/web/lib/reschedule/[uid]/getServerSideProps.ts

+    }
+  }
+
+  const isHostOrOwner = !!userIsHost || !!userIsOwnerOfEventType || !!hasTeamOrOrgPermissions;


The permission-calculation logic (userIsHost / userIsOwnerOfEventType / hasTeamOrOrgPermissions) is duplicated later in the same function, causing two additional database calls (isTeamAdmin, isOrganisationAdmin) per request. This hurts performance and maintainability; consider extracting a helper or computing once and re-using the result.

cubic-dev-ai · 2025-07-09T02:55:08Z

apps/web/lib/team/[slug]/[type]/getServerSideProps.tsx

+      }
+    }
+  }
+  const isHostOrOwner =


Authorization relies on eventData.hosts which is limited to the first 3 hosts (because of take: 3 in the Prisma query). If an event has more than three hosts, legitimate hosts outside this slice will fail the check and be redirected, effectively blocking them from rescheduling/cancelling their own event.

Nice catch, fixed it by querying it separately

cubic-dev-ai

cubic found 2 issues across 9 files. Review them in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

apps/web/lib/reschedule/[uid]/getServerSideProps.ts

apps/web/lib/team/[slug]/[type]/getServerSideProps.tsx

…er is the host and fix type error

asadath1395 · 2025-07-09T03:22:01Z

Along with the host, Team/Org Admin and Owner should also be able to reschedule or cancel the booking.

@kart1ka Thanks for flagging this. I have fixed it and added tests too. Please test this again and let me know if you find anything

…able-rescheduling-cancelling

kart1ka · 2025-09-04T07:04:47Z

I have a few comments:

We should disable "Request for Reschedule" option when disable reschedule is toggled on otherwise it defeats the purpose of disabling reschedule.

It still does not work properly for org/team admin or owner. cancel and reschedule option is still not shown on booking detail page.

cancel and reschedule does not work for team/org admin and owner at all even when triggered from booking list item.

Please see the attached video: cap.link/ctb7sb9011xwj15
This would also require tests to make sure everything works fine.

@kart1ka Your video shows a strange shift from acme to app subdomain, i think it means different orgs. Could you try it consistently with the same subdomain/org?

@asadath1395 Using different subdomains makes no difference here.

…able-rescheduling-cancelling

… are disabled

…able-rescheduling-cancelling

…idual event types when both are disabled

…com/asadath1395/cal.com into fix/disable-rescheduling-cancelling

asadath1395 · 2025-09-15T14:08:07Z

I have a few comments:

We should disable "Request for Reschedule" option when disable reschedule is toggled on otherwise it defeats the purpose of disabling reschedule.

Can you create a new issue for this? Let's not increase the scope of this PR

It still does not work properly for org/team admin or owner. cancel and reschedule option is still not shown on booking detail page.

cancel and reschedule does not work for team/org admin and owner at all even when triggered from booking list item.

Please see the attached video: https://cap.link/ctb7sb9011xwj15

This would also require tests to make sure everything works fine.

@kart1ka Mind testing this again. I have added tests too.

dhairyashiil

could you resolve the merge conflicts? making it a draft until then

dhairyashiil · 2025-11-21T19:38:00Z

Closing the PR due to staleness.

fix: Hosts not able to cancel/reschedule the event when Disable Resch…

6b0cbc8

…eduling/Cancelling is enabled

asadath1395 requested a review from a team as a code owner July 7, 2025 06:03

graphite-app bot added the community Created by Linear-GitHub Sync label Jul 7, 2025

graphite-app bot requested a review from a team July 7, 2025 06:03

github-actions bot added Public 🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Jul 7, 2025

dosubot bot added the bookings area: bookings, availability, timezones, double booking label Jul 7, 2025

cubic-dev-ai bot reviewed Jul 7, 2025

View reviewed changes

asadath1395 and others added 2 commits July 7, 2025 11:42

Fix logic bypass

fe5cc0b

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Fix cubic comment

cb4fb4c

kart1ka suggested changes Jul 7, 2025

View reviewed changes

kart1ka marked this pull request as draft July 7, 2025 17:38

Merge branch 'main' of https://github.com/calcom/cal.com into fix/dis…

9fad7a2

…able-rescheduling-cancelling

anikdhabal mentioned this pull request Jul 8, 2025

fix: allow hosts to cancel bookings when disableCancelling is enabled #22310

Closed

anikdhabal and others added 6 commits July 8, 2025 18:25

Merge branch 'main' into fix/disable-rescheduling-cancelling

f4adb8d

Fix team/org admins/owners mot able to reschedule/cancel when they ar…

8edc297

…e disabled in event type

Merge branch 'fix/disable-rescheduling-cancelling' of https://github.…

8542dca

…com/asadath1395/cal.com into fix/disable-rescheduling-cancelling

Fix type error

2e8b63b

Merge branch 'main' of https://github.com/calcom/cal.com into fix/dis…

a88aa94

…able-rescheduling-cancelling

Improve imports and function params typing

15a5262

asadath1395 marked this pull request as ready for review July 9, 2025 02:50

cubic-dev-ai bot reviewed Jul 9, 2025

View reviewed changes

apps/web/lib/reschedule/[uid]/getServerSideProps.ts Outdated Show resolved Hide resolved

apps/web/lib/team/[slug]/[type]/getServerSideProps.tsx Outdated Show resolved Hide resolved

asadath1395 added 2 commits July 9, 2025 08:39

Remove duplicate permission check, fix auth logic to check whether us…

b134b7a

…er is the host and fix type error

Remove duplicate permission check

bab5c12

Merge branch 'main' of https://github.com/calcom/cal.com into fix/dis…

25875b6

…able-rescheduling-cancelling

github-actions bot removed the Stale label Sep 4, 2025

anikdhabal mentioned this pull request Sep 4, 2025

fix: allow owners to cancel events even if cancellation is disabled #23472

Closed

3 tasks

asadath1395 added 2 commits September 4, 2025 12:11

Merge branch 'main' of https://github.com/calcom/cal.com into fix/dis…

85ca61a

…able-rescheduling-cancelling

Simplify team or org permission check

02ebfd8

pull-request-size bot added the size/XL label Sep 4, 2025

asadath1395 added 5 commits September 4, 2025 12:42

Fix userId undefined

610e162

Fix type error

02fb9da

Merge branch 'main' of https://github.com/calcom/cal.com into fix/dis…

6077874

…able-rescheduling-cancelling

Fix org owner/admin not able to reschedule/cancel a booking when both…

0b26e3a

… are disabled

Merge branch 'main' of https://github.com/calcom/cal.com into fix/dis…

98594cb

…able-rescheduling-cancelling

github-actions bot added Low priority Created by Linear-GitHub Sync Stale labels Sep 15, 2025

Add org tests to validate owner/admin able to reschedule/cancel indiv…

166a5f7

…idual event types when both are disabled

asadath1395 marked this pull request as ready for review September 15, 2025 11:48

asadath1395 and others added 3 commits September 15, 2025 17:18

Merge branch 'main' into fix/disable-rescheduling-cancelling

5f89e3d

Fix type in tests

c163681

Merge branch 'fix/disable-rescheduling-cancelling' of https://github.…

41c26b4

…com/asadath1395/cal.com into fix/disable-rescheduling-cancelling

asadath1395 requested a review from kart1ka September 15, 2025 13:58

github-actions bot removed the Stale label Sep 16, 2025

Merge branch 'main' into fix/disable-rescheduling-cancelling

b81a194

github-actions bot added the Stale label Sep 17, 2025

dhairyashiil reviewed Nov 9, 2025

View reviewed changes

dhairyashiil removed the request for review from kart1ka November 9, 2025 21:28

dhairyashiil marked this pull request as draft November 9, 2025 21:28

dhairyashiil removed the Medium priority Created by Linear-GitHub Sync label Nov 21, 2025

dhairyashiil closed this Nov 21, 2025

Comments

Conversation

asadath1395 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Visual Demo (For contributors especially)

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Uh oh!

vercel bot commented Jul 7, 2025

Uh oh!

graphite-app bot commented Jul 7, 2025

Graphite Automations

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

asadath1395 Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

kart1ka left a comment

Choose a reason for hiding this comment

Uh oh!

kart1ka commented Jul 7, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

asadath1395 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

asadath1395 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

asadath1395 commented Jul 9, 2025

Uh oh!

kart1ka commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asadath1395 commented Sep 15, 2025

Uh oh!

dhairyashiil left a comment

Choose a reason for hiding this comment

Uh oh!

dhairyashiil commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

asadath1395 commented Jul 7, 2025 •

edited

Loading

kart1ka commented Sep 4, 2025 •

edited

Loading